Always set IMPORTED_LOCATION #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also test that rust dependencies link with foreign code
Not setting IMPORTED_LOCATION on imported executables causes CMake developer warnings. Setting IMPORTED_LOCATION_<CONFIG> is not sufficient. The issue only affects Multi-Config Generators like Ninja-MultiConfig or Visual Studio, since otherwise IMPORTED_LOCATION is already always set. For Multi-Config builds there is no "correct" thing to set IMPORTED_LOCATION to, so we just always set it, and the last configuration wins. This is not a problem since the more specific IMPORTED_LOCATION_<CONFIG> variants are also set in the multi-config case. This commit refactors a bit of common code into a function, so that both CorrosionGenerator.cmake and the Rust based CMake Generator can use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not setting
IMPORTED_LOCATIONon imported executables causes CMakedeveloper warnings. Setting
IMPORTED_LOCATION_<CONFIG>is not sufficient.The issue only affects Multi-Config Generators like Ninja-MultiConfig or
Visual Studio, since otherwise
IMPORTED_LOCATIONis already always set.For Multi-Config builds there is no "correct" thing to set
IMPORTED_LOCATIONto, so we just always set it, and the last configurationwins. This is not a problem since the more specific
IMPORTED_LOCATION_<CONFIG>variants are also set in the multi-config case.