Don't set linker for Rust static libraries #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwe
force-pushed
the
static_lib_no_set_linker
branch
from
13e9461
to
10daa3f
Compare
As discussed in issue corrosion-rs#270 we at least should not set the linker for Rust static libraries. In the general case the linker is not needed for static libraries, and if it is invoked, Rust should take care of what to choose (e.g. for building build scripts) instead of us forcing the choice.
jschwe
force-pushed
the
static_lib_no_set_linker
branch
from
10daa3f
to
7e30477
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #270 we at least should not set the linker for Rust static libraries. In the general case the linker is not needed for static libraries, and if it is invoked,
Rust should take care of what to choose
(e.g. for building build scripts) instead
of us forcing the choice.