Improve Multi-Config checks #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a warning if CMAKE_CONFIGURATION_TYPES is defined, but the generator is not a multi-config generator. - Check `GENERATOR_IS_MULTI_CONFIG` instead of checking `CMAKE_CONFIGURATION_TYPES` to be more robust in case a user accidantally specifies `CMAKE_CONFIGURATION_TYPES` manually but is using a single-config generator. `GENERATOR_IS_MULTI_CONFIG` is read-only property, so users can't override it.
jschwe
force-pushed
the
multi_config_checks
branch
from
fbbe27a
to
75aba9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GENERATOR_IS_MULTI_CONFIGinstead of checkingCMAKE_CONFIGURATION_TYPESto be more robust in case a user accidantally specifiesCMAKE_CONFIGURATION_TYPESmanually but is using a single-config generator.GENERATOR_IS_MULTI_CONFIGis read-only property, so users can't override it.