move logic from checkout#success to webhooks

corsego · Mar 9, 2021 · aa726bc · aa726bc
1 parent 34f2a38
commit aa726bc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/app/controllers/checkout_controller.rb b/app/controllers/checkout_controller.rb
@@ -19,11 +19,11 @@ def create
   end
 
   def success
-    session_with_expand = Stripe::Checkout::Session.retrieve({ id: params[:session_id], expand: ["line_items"]})
-    session_with_expand.line_items.data.each do |line_item|
-      product = Product.find_by(stripe_product_id: line_item.price.product)
-      product.increment!(:sales_count)
-    end
+    # session_with_expand = Stripe::Checkout::Session.retrieve({ id: params[:session_id], expand: ["line_items"]})
+    # session_with_expand.line_items.data.each do |line_item|
+    #   product = Product.find_by(stripe_product_id: line_item.price.product)
+    #   product.increment!(:sales_count)
+    # end
   end
 
   def cancel

diff --git a/app/controllers/webhooks_controller.rb b/app/controllers/webhooks_controller.rb
@@ -25,8 +25,11 @@ def create
     case event.type
     when 'checkout.session.completed'
       session = event.data.object
-      @product = Product.find_by(price: session.amount_total)
-      @product.increment!(:sales_count)
+      session_with_expand = Stripe::Checkout::Session.retrieve({ id: session.id, expand: ["line_items"]})
+      session_with_expand.line_items.data.each do |line_item|
+        product = Product.find_by(stripe_product_id: line_item.price.product)
+        product.increment!(:sales_count)
+      end
     end
 
     render json: { message: 'success' }