Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow destination shape to be specified in reproject() #116

Merged
merged 9 commits into from Jun 11, 2020

Conversation

davidbrochart
Copy link
Contributor

@davidbrochart davidbrochart commented Jun 10, 2020

  • Tests added
  • Fully documented, including docs/history.rst for all changes and docs/rioxarray.rst for new API

@davidbrochart
Copy link
Contributor Author

This PR is ready to be reviewed. It allows passing dst_height and dst_width instead of resolution in calculate_default_transform.
Please note that flake8 v3.8 will break.

rioxarray/rioxarray.py Outdated Show resolved Hide resolved
@snowman2
Copy link
Member

@davidbrochart, this looks great, thanks 👍. Just a minor comment above and I think that it would be good to add another test that ensures the output shape is expected when using the shape argument. Would you mind adding that in?

@snowman2
Copy link
Member

Also, just thought of this - mind adding .. versionadded:: 0.0.27 shape to above the parameters section in the docstrings of both reproject methods?

@snowman2
Copy link
Member

@davidbrochart did you want to squash your commits with me doing a merge commit or would you rather I just do a squash-and-merge?

@davidbrochart
Copy link
Contributor Author

Yes, please go ahead and do a squash-and-merge.

@snowman2 snowman2 merged commit d295c20 into corteva:master Jun 11, 2020
@snowman2
Copy link
Member

Thanks @davidbrochart for this addition 👍

@davidbrochart
Copy link
Contributor Author

Thanks a lot for this awesome library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants