Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add pad_box() #138

Merged
merged 5 commits into from
Jun 23, 2020
Merged

ENH: Add pad_box() #138

merged 5 commits into from
Jun 23, 2020

Conversation

davidbrochart
Copy link
Contributor

@davidbrochart davidbrochart commented Jun 20, 2020 •
edited

@davidbrochart davidbrochart changed the title [WIP] Add optional padding to clip_box() Add optional padding to clip_box() Jun 20, 2020
@davidbrochart davidbrochart force-pushed the clip_extend branch 4 times, most recently from 6ca0045 to 250f179 Compare June 20, 2020 21:10
snowman2
snowman2 reviewed Jun 22, 2020
View reviewed changes
rioxarray/rioxarray.py Outdated Show resolved Hide resolved
snowman2
snowman2 reviewed Jun 22, 2020
View reviewed changes
rioxarray/rioxarray.py Outdated Show resolved Hide resolved
snowman2
snowman2 reviewed Jun 22, 2020
View reviewed changes
rioxarray/rioxarray.py Outdated Show resolved Hide resolved
@davidbrochart davidbrochart mentioned this pull request Jun 22, 2020
Closed
@davidbrochart
Copy link
Contributor Author

Actually there is a bug, the padding doesn't take into account the previous clipping. So maybe .clip_box() should be left as it is, and we should have a new .pad_box() method? Things like clipping on the right and padding on the left would be achieved by calling .clip_box() then .pad_box().

@snowman2
Copy link
Member

So maybe .clip_box() should be left as it is, and we should have a new .pad_box() method?

That makes sense to me at this stage.

@davidbrochart davidbrochart changed the title Add optional padding to clip_box() Add pad_box() Jun 22, 2020
snowman2
snowman2 reviewed Jun 22, 2020
View reviewed changes
rioxarray/rioxarray.py Outdated Show resolved Hide resolved
@snowman2 snowman2 changed the title Add pad_box() ENH: Add pad_box() Jun 23, 2020
@snowman2
Copy link
Member

@davidbrochart this looks great, thanks!

@snowman2 snowman2 merged commit e647471 into corteva:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowman2 snowman2 snowman2 left review comments

@jgruca jgruca jgruca approved these changes

@alfredoahds alfredoahds Awaiting requested review from alfredoahds

@justingruca justingruca Awaiting requested review from justingruca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make clip_box extend array
3 participants
@davidbrochart @snowman2 @jgruca