Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix assigning fill value in rio.pad_box #140

Merged
merged 2 commits into from
Jun 23, 2020
Merged

BUG: Fix assigning fill value in rio.pad_box #140

merged 2 commits into from
Jun 23, 2020

Conversation

snowman2
Copy link
Member

Discovered this while debugging something else.

I was incorrect about the encoded_nodata as the data in the array will be np.nan when encoded_nodata is set. In this case, it would be better to leave it as np.nan.

cc: @davidbrochart

  • Tests updated
  • Fully documented, including docs/history.rst for all changes and docs/rioxarray.rst for new API

@snowman2 snowman2 merged commit cc2ed4f into master Jun 23, 2020
@snowman2 snowman2 deleted the padboxfix branch June 23, 2020 19:03
@davidbrochart
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants