Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on numpy>=1.21 to fix installation issue #636

Merged
merged 2 commits into from Feb 22, 2023

Conversation

itcarroll
Copy link
Contributor

@itcarroll itcarroll commented Feb 15, 2023

  • Closes import error caused by old numpy version #587
  • Tests added Not sure how to write a test for an installation. Checks out locally with poetry though.
  • Fully documented, including docs/history.rst for all changes and docs/rioxarray.rst for new API

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 95.90% // Head: 95.90% // No change to project coverage 👍

Coverage data is based on head (afcf16f) compared to base (9d59756).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #636   +/-   ##
=======================================
  Coverage   95.90%   95.90%           
=======================================
  Files          12       12           
  Lines        1735     1735           
=======================================
  Hits         1664     1664           
  Misses         71       71           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@itcarroll
Copy link
Contributor Author

Check failure appears unrelated to me. Anaconda's nightly scipy looks pinned to an old version of setuptools ... maybe?

@snowman2
Copy link
Member

Thanks @itcarroll 👍

@snowman2 snowman2 merged commit 8a18c90 into corteva:master Feb 22, 2023
@snowman2 snowman2 added this to the 0.13.4 milestone Feb 22, 2023
@itcarroll itcarroll deleted the bugfix-587 branch February 22, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import error caused by old numpy version
3 participants