Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Use rasterio.io.MemoryFile in merge #765

Merged
merged 1 commit into from Apr 2, 2024
Merged

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 commented Apr 2, 2024

Related: #204 (comment)

Failing tests: https://github.com/corteva/rioxarray/actions/runs/8126712662/job/22210778353

FAILED test/integration/test_integration_merge.py::test_merge_arrays[True] - AssertionError: 
Arrays are not almost equal to 7 decimals
 ACTUAL: <xarray.DataArray '__xarray_dataarray_variable__' ()> Size: 8B
array(-854871110)
Coordinates:...
 DESIRED: 22865733
FAILED test/integration/test_integration_merge.py::test_merge_arrays[False] - AssertionError: 
Arrays are not almost equal to 7 decimals
 ACTUAL: <xarray.DataArray '__xarray_dataarray_variable__' ()> Size: 8B
array(-854871110)
Coordinates:
    spatial_ref  int64 8B 0
 DESIRED: 22865733
FAILED test/integration/test_integration_merge.py::test_merge__different_crs[True] - AssertionError: 
Arrays are not almost equal to 7 decimals
 ACTUAL: <xarray.DataArray '__xarray_dataarray_variable__' ()> Size: 8B
array(-231858673)
Coordinates:
    spatial_ref  int64 8B 0
 DESIRED: -131734881
FAILED test/integration/test_integration_merge.py::test_merge__different_crs[False] - AssertionError: 
Arrays are not almost equal to 7 decimals
 ACTUAL: <xarray.DataArray '__xarray_dataarray_variable__' ()> Size: 8B
array(-231858673)
Coordinates:
    spatial_ref  int64 8B 0
 DESIRED: -131734881
FAILED test/integration/test_integration_merge.py::test_merge_arrays__res - AssertionError: 
Arrays are not almost equal to 7 decimals
 ACTUAL: 3132355.0
 DESIRED: 13760565

@snowman2 snowman2 added the bug Something isn't working label Apr 2, 2024
@snowman2 snowman2 added this to the 0.15.2 milestone Apr 2, 2024
@snowman2 snowman2 modified the milestones: 0.15.2, 0.15.3 Apr 2, 2024
@snowman2
Copy link
Member Author

snowman2 commented Apr 2, 2024

Thanks @justingruca 👍

@snowman2 snowman2 merged commit f0f4efc into corteva:master Apr 2, 2024
17 of 19 checks passed
@snowman2 snowman2 deleted the merge branch April 2, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants