Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CE-306: Testing Infrastructure + Engine Rebuild #554

Merged
merged 2 commits into from
Feb 5, 2018

Conversation

toastercup
Copy link
Member

@toastercup toastercup commented Jan 24, 2018

Purpose
To accomodate our new testing infrastructure, Cortex was migrated to an Engine, so that a parent application can compose it as a dependency along with any other plugins. An example parent application may be a dummy test app, or it may be the actual host Rails application for a company's Cortex instance, such as CareerBuilder.

JIRA
https://careerbuilder.atlassian.net/browse/CE-306

Changes

  • Improvements and fixes

    • Refactors codebase into a Rails Engine
    • Webpacker-related assets now distributed as Yarn package
    • Prop up dummy spec app that mounts Cortex Engine
    • Initial RSpec config
    • Namespace all constants/assets within Cortex namespace
    • New material-icons utility classes
    • Migrate all client-side dependencies from Gems to Yarn packages
    • Switches to Sprockets v4 manifest for asset config
    • Cleans up gemspec/Gemfile; unnecessary dependencies removed
    • Expanded/cleaned up gitignore
    • Prep for Rails 5.2
    • Application + Devise layout improvements
    • Devise config + locale improvements
    • Mailer config + layout improvements
    • Binstub improvements
    • Removes Hashr dependency
    • Code refactors + cleanup
  • Changes to developer setup/environment

    • Yes - please review PR
  • Architectural changes

    • Yes - please review PR
  • Migrations or Steps to Take on Production

    • This will require a full rebuild of all servers
  • Library changes

    • Yes - cortex-plugins-core has been updated to be compatible with these changes.
  • Side effects

    • N/A

Screenshots

  • Before
    N/A

  • After
    N/A

Feature Server
No servers are currently compatible with the Beta Cortex Rebuild. We'll have a story in an upcoming sprint to set these up. In the meantime, you'll want to test this out by cloning and launching https://github.com/cortex-cms/cortex-starter

How to Verify These Changes

  • Specific pages to visit

    • Test whole application
  • Steps to take

    • Test whole application
  • Responsive considerations

    • N/A

Relevant PRs/Dependencies

Additional Information
N/A

@toastercup toastercup changed the title feat(Rebuild): convert Cortex to a Rails Engine CE-306: Testing Infrastructure Jan 24, 2018
@toastercup toastercup force-pushed the topic/CE-306-Testing-Infrastructure branch 2 times, most recently from 4bb1138 to 5affd10 Compare January 25, 2018 22:34
@toastercup toastercup changed the title CE-306: Testing Infrastructure CE-306: Testing Infrastructure + Engine Rebuild Jan 25, 2018
@toastercup toastercup force-pushed the topic/CE-306-Testing-Infrastructure branch from 5affd10 to 810f781 Compare January 26, 2018 21:40
@toastercup toastercup force-pushed the topic/CE-306-Testing-Infrastructure branch from 810f781 to b35560c Compare January 26, 2018 21:45
@toastercup
Copy link
Member Author

@MKwenhua @mrfantasticwonders this PR is ready for your review.

@toastercup toastercup merged commit fbad48d into develop Feb 5, 2018
@toastercup toastercup deleted the topic/CE-306-Testing-Infrastructure branch February 5, 2018 17:43
toastercup pushed a commit that referenced this pull request Feb 6, 2018
CE-306: Testing Infrastructure + Engine Rebuild
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants