Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move & rename replica parallelism fields #1158

Merged
merged 16 commits into from Jun 24, 2020

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Jun 23, 2020

Closes #960, closes #1090.


checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update examples
  • update docs and add any new files to summary.md (view in gitbook after merging)

@RobertLucian RobertLucian added enhancement New feature or request refactor Improve code quality labels Jun 23, 2020
# Conflicts:
#	examples/tensorflow/image-classifier-resnet50/cortex_cpu.yaml
#	examples/tensorflow/image-classifier-resnet50/cortex_gpu.yaml
#	examples/tensorflow/image-classifier-resnet50/cortex_inf.yaml
#	examples/tensorflow/license-plate-reader/cortex_full.yaml
#	pkg/types/userconfig/config_key.go
cli/local/docker_spec.go Outdated Show resolved Hide resolved
@RobertLucian
Copy link
Member Author

Tested this with various examples. In these examples, it has been tested with different values for processes_per_replica and threads_per_process. This also included verifications that the CloudWatch dashboard, the endpoints and the multi-model feature work.

Copy link
Member

@deliahu deliahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick turnaround on this!

@RobertLucian RobertLucian merged commit c4b1994 into master Jun 24, 2020
@RobertLucian RobertLucian deleted the refactor/parallelism-fields branch June 24, 2020 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Improve code quality
Projects
None yet
2 participants