Validate # of security groups and in/out rules before clustering up #2127

RobertLucian · 2021-04-27T22:22:37Z

Closes #2087.

checklist:

run make test and make lint
test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

pkg/lib/aws/errors.go

pkg/lib/aws/servicequotas.go

RobertLucian added 4 commits April 27, 2021 23:33

Validate number of SGs and inbound/outbound rules

aefdb23

Merge branch 'master' into reliability/security-groups-validations

ce0c9b2

Fix network validation

dde5cc0

Merge branch 'master' into reliability/security-groups-validations

7be66ea

RobertLucian requested a review from deliahu April 27, 2021 22:22

RobertLucian changed the title ~~Validate num of security groups and in/out rules before clustering up~~ Validate # of security groups and in/out rules before clustering up Apr 27, 2021

RobertLucian added 4 commits April 28, 2021 16:55

Merge branch 'master' into reliability/security-groups-validations

a386a84

Factor in the number of CIDR white list rules

f6dbeda

Fix logic when CIDR list is specified

6e04f94

Fix CIDR list rules logic

185967d

deliahu approved these changes Apr 28, 2021

View reviewed changes

Address PR nits

f442033

RobertLucian merged commit ab651d8 into master Apr 28, 2021

RobertLucian deleted the reliability/security-groups-validations branch April 28, 2021 23:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate # of security groups and in/out rules before clustering up #2127

Validate # of security groups and in/out rules before clustering up #2127

RobertLucian commented Apr 27, 2021 •

edited

Validate # of security groups and in/out rules before clustering up #2127

Validate # of security groups and in/out rules before clustering up #2127

Conversation

RobertLucian commented Apr 27, 2021 • edited

RobertLucian commented Apr 27, 2021 •

edited