Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix autoscaler behaviour when encountering zero-valued recommendations #2350

Merged
merged 7 commits into from
Jul 19, 2021
Merged

Fix autoscaler behaviour when encountering zero-valued recommendations #2350

merged 7 commits into from
Jul 19, 2021

Conversation

miguelvr
Copy link
Collaborator

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@miguelvr miguelvr requested a review from deliahu July 16, 2021 12:22
deliahu
deliahu reviewed Jul 16, 2021
View reviewed changes
pkg/autoscaler/autoscaler.go Show resolved Hide resolved
pkg/autoscaler/autoscaler.go Outdated Show resolved Hide resolved
pkg/autoscaler/autoscaler.go Show resolved Hide resolved
@miguelvr miguelvr merged commit 533852e into master Jul 19, 2021
@miguelvr miguelvr deleted the fix/autoscaler branch July 19, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miguelvr @deliahu