New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the node groups selector part of the API spec ID #2354

Merged

RobertLucian merged 1 commit into master from fix/api-node-groups-update

Jul 17, 2021

Member

RobertLucian commented Jul 17, 2021 •

edited

Without this, running a cortex deploy <api-name> on an existing API that has had the node_groups section updated won't get updated.

checklist:

run make test and make lint
test manually (i.e. build/push all images, restart operator, and re-deploy APIs)


          Include the node groups selector in the API spec ID

480333e

RobertLucian added the bug label

RobertLucian requested a review from deliahu

July 17, 2021 03:24

deliahu approved these changes

View reviewed changes

RobertLucian merged commit 7e7fabc into master

RobertLucian deleted the fix/api-node-groups-update branch

July 17, 2021 05:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment