Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect priority on the priority expander of the cluster autoscaler #2358

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Fix incorrect priority on the priority expander of the cluster autoscaler #2358

merged 3 commits into from
Jul 19, 2021

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Jul 19, 2021 •
edited

Apparently, the priority expander (of the cluster autoscaler) sees higher values as having a higher priority, not a lower priority. This needs fixing on our part. As explained here: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/expander/priority/readme.md#configuration

The priority should be a positive value. The highest value wins.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian merged commit a6366b7 into master Jul 19, 2021
@RobertLucian RobertLucian deleted the fix/priority-of-node-groups branch July 19, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

@miguelvr miguelvr miguelvr approved these changes

@vishalbollu vishalbollu Awaiting requested review from vishalbollu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RobertLucian @deliahu @miguelvr