Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a shared async gateway between all async apis #2380

Merged
merged 5 commits into from
Jul 30, 2021
Merged

Use a shared async gateway between all async apis #2380

merged 5 commits into from
Jul 30, 2021

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Jul 29, 2021 •
edited

closes #2279

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@vishalbollu vishalbollu marked this pull request as ready for review July 30, 2021 14:04
@vishalbollu vishalbollu requested a review from deliahu July 30, 2021 14:10
miguelvr
miguelvr approved these changes Jul 30, 2021
View reviewed changes
Copy link
Collaborator

@miguelvr miguelvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deliahu
deliahu approved these changes Jul 30, 2021
View reviewed changes
manager/manifests/async-gateway.yaml.j2 Outdated Show resolved Hide resolved
pkg/async-gateway/service.go Show resolved Hide resolved
@vishalbollu vishalbollu merged commit 2203a92 into master Jul 30, 2021
@vishalbollu vishalbollu deleted the shared-async-gateway branch July 30, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

@miguelvr miguelvr miguelvr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a shared async gateway deployment which runs on the operator node group
3 participants
@vishalbollu @deliahu @miguelvr