Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reported pricing for spot node-groups with on-demand alternative #2406

Merged
merged 3 commits into from
Dec 6, 2021
Merged

Fix reported pricing for spot node-groups with on-demand alternative #2406

merged 3 commits into from
Dec 6, 2021

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Dec 6, 2021 •
edited

Fixes #2405.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian added the bug Something isn't working label Dec 6, 2021
@RobertLucian RobertLucian merged commit 87f54bd into master Dec 6, 2021
@RobertLucian RobertLucian deleted the fix/spot-ng-cost-calculation branch December 6, 2021 23:47
deliahu pushed a commit that referenced this pull request Dec 7, 2021
@RobertLucian @deliahu
Fix reported pricing for spot node-groups with on-demand alternative (#…
6ae1cec 
…2406)

(cherry picked from commit 87f54bd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cost calculation wrong if a mix of spot and demand instances is used
2 participants
@RobertLucian @deliahu