Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Column.GetType() from string to ColumnType #25

Merged
merged 9 commits into from Feb 28, 2019
Merged

Convert Column.GetType() from string to ColumnType #25

merged 9 commits into from Feb 28, 2019

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Feb 27, 2019 •
edited

Checklist:

  • Run automated tests (make test)
  • Test end to end manually (e.g. rebuild registry/operator and run cx refresh in an example folder)
  • Add license header to each new file
  • Update documentation
  • Update examples and cx init
  • Alert team if dev environment changed
  • Cherry-pick into release branches if it's a bugfix
  • Delete the branch once it's merged

@deliahu deliahu requested a review from 1vn February 27, 2019 20:27
1vn
1vn previously approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@1vn 1vn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1vn
1vn approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@1vn 1vn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deliahu deliahu merged commit 23f4bda into master Feb 28, 2019
@deliahu deliahu deleted the column-type branch February 28, 2019 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1vn 1vn 1vn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deliahu @1vn