Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Column.GetType() from string to ColumnType #25

Merged
merged 9 commits into from Feb 28, 2019

Conversation

Projects
None yet
2 participants
@deliahu
Copy link
Member

deliahu commented Feb 27, 2019


Checklist:

  • Run automated tests (make test)
  • Test end to end manually (e.g. rebuild registry/operator and run cx refresh in an example folder)
  • Add license header to each new file
  • Update documentation
  • Update examples and cx init
  • Alert team if dev environment changed
  • Cherry-pick into release branches if it's a bugfix
  • Delete the branch once it's merged

@deliahu deliahu requested a review from 1vn Feb 27, 2019

Show resolved Hide resolved pkg/api/userconfig/raw_columns.go Outdated
@1vn
Copy link
Member

1vn left a comment

LGTM

@1vn

1vn approved these changes Feb 28, 2019

Copy link
Member

1vn left a comment

LGTM

@deliahu deliahu merged commit 23f4bda into master Feb 28, 2019

1 check passed

ci/circleci: test Your tests passed on CircleCI!
Details

@deliahu deliahu deleted the column-type branch Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.