Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alertmanager templates load doesn't support mutiple level files #12

Closed
songjiayang opened this issue Feb 10, 2023 · 0 comments · Fixed by #33
Closed

Alertmanager templates load doesn't support mutiple level files #12

songjiayang opened this issue Feb 10, 2023 · 0 comments · Fixed by #33
Assignees
@CharlieTLe
Labels
enhancement New feature or request

Comments

@songjiayang
Copy link

cortextool alertmanager load ./tmp/rules.yaml ./tmp/fool.tmpl execution failed. Because cortex backend doesn't support ./tmp/fool.tmpl template name. Can we filepath.Base the config file name before post data to backend. related code commands/alerts.go#L129

templates[f] = string(tmpl)  => templates[filepath.Base(f)] = string(tmpl)
@CharlieTLe CharlieTLe added the enhancement New feature or request label Apr 24, 2024
CharlieTLe added a commit to CharlieTLe/cortex-tools that referenced this issue Apr 25, 2024
@CharlieTLe
Support loading alertmanager template files in different directories
fda8747 
Fixes cortexproject#12

Signed-off-by: Charlie Le <charlie_le@apple.com>
@CharlieTLe CharlieTLe mentioned this issue Apr 25, 2024
Merged
@CharlieTLe CharlieTLe self-assigned this Apr 25, 2024
friedrichg pushed a commit that referenced this issue Apr 29, 2024
@CharlieTLe
Support loading alertmanager template files in different directories (#…
1bf462a 
…33)

Fixes #12

Signed-off-by: Charlie Le <charlie_le@apple.com>
friedrichg pushed a commit that referenced this issue May 9, 2024
@CharlieTLe @friedrichg
Support loading alertmanager template files in different directories (#…
81c5f1b 
…33)

Fixes #12

Signed-off-by: Charlie Le <charlie_le@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CharlieTLe CharlieTLe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support loading alertmanager template files in different directories CharlieTLe/cortex-tools
2 participants
@songjiayang @CharlieTLe