Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky TestSweepImmediateDropsSamples #2825

Closed
pracucci opened this issue Jul 2, 2020 · 2 comments · Fixed by #2834
Closed

Flaky TestSweepImmediateDropsSamples #2825

pracucci opened this issue Jul 2, 2020 · 2 comments · Fixed by #2834
Assignees

Comments

@pracucci
Copy link
Contributor

pracucci commented Jul 2, 2020

While running the CI (see here) for a PR doing changes unrelated to flushing, I've noticed that TestSweepImmediateDropsSamples is flaky.

The test has been recently introduced in #2778.

@pracucci
Copy link
Contributor Author

pracucci commented Jul 7, 2020

I'm reopening the issue because this test is still flaky (see here):

--- FAIL: TestSweepImmediateDropsSamples (0.01s)
    flush_test.go:97: 
        	Error Trace:	flush_test.go:97
        	            				flush_test.go:41
        	            				flush.go:354
        	            				flush.go:319
        	            				flush.go:220
        	            				asm_amd64.s:1373
        	Error:      	Received unexpected error:
        	            	rpc error: code = Code(500) desc = user=1: ingester stopping
        	Test:       	TestSweepImmediateDropsSamples
    flush_test.go:52: 
        	Error Trace:	flush_test.go:52
        	Error:      	Not equal: 
        	            	expected: 2
        	            	actual  : 0
        	Test:       	TestSweepImmediateDropsSamples

@pstibrany
Copy link
Contributor

I think that PR is based on older master (54f10c2) without the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants