Make label name character set validation optional #2835
Conversation
Signed-off-by: replay <mauro.stettler@gmail.com>
replay
changed the title
pkg/util/validation/limits.go
Outdated
| @@ -38,6 +38,7 @@ type Limits struct { | |||
| CreationGracePeriod time.Duration `yaml:"creation_grace_period"` | |||
| EnforceMetadataMetricName bool `yaml:"enforce_metadata_metric_name"` | |||
| EnforceMetricName bool `yaml:"enforce_metric_name"` | |||
| EnforceLabelNameCharset bool `yaml:enforce_label_name_charset"` | |||
There was a problem hiding this comment.
Do we want to expose this option to Cortex users? Or is it supposed to be only internal flag used by extension you’re writing? (I would prefer later, but if there is good reason to expose, we can keep it)
There was a problem hiding this comment.
Same concern here. I would prefer to avoid making it configurable to Cortex users unless there's a legit use case for that.
There was a problem hiding this comment.
Ok, no problem, i'll remove the flag so that the setting isn't exposed to the user. I'll add a parameter to validation.ValidateLabels() then, to skip the label name validation. I'll also extend the unit tests to test that flag
Signed-off-by: replay <mauro.stettler@gmail.com>
replay
force-pushed
the
make_label_name_validation_optional
branch
from
b48ab32
to
c74b572
Compare
|
One test has failed in the CI, but when I run it locally it passes fine. I can't trigger a re-run without write permissions, but is it possible that this test is unstable ( |
Yes, this test is flaky. I've re-opened the issue about it #2825. Definitely not something you have to fix. |
| if cfg.EnforceMetricName(userID) { | ||
| metricName, err := extract.MetricNameFromLabelAdapters(ls) |
There was a problem hiding this comment.
Thanks for fixing this (moving it inside the branch)!
Signed-off-by: replay <mauro.stettler@gmail.com>
This removes the
SkipLabelValidationdistributor config property again and introduces a new flag called-validation.enforce-label-name-charset. That config flag can be used to disable the enforcement of the prometheus character set restrictions when validating label names, to allow for a wider set of characters in label names.The advantage of doing it this way is that the enforcement of the label name charset can be disabled specifically, while all the other label limits (
-validation.max-length-label-name,-validation.max-length-label-value, etc) remain in place.