Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingester emitting two identical trace spans for every Push call #3168

Closed
bboreham opened this issue Sep 13, 2020 · 2 comments · Fixed by #3175
Closed

Ingester emitting two identical trace spans for every Push call #3168

bboreham opened this issue Sep 13, 2020 · 2 comments · Fixed by #3175
Labels
component/ingester type/observability To help know what is going on inside Cortex

Comments

@bboreham
Copy link
Contributor

Identical except for slight differences in timing.
Do we add the middleware twice?

image

@bboreham bboreham added component/ingester type/observability To help know what is going on inside Cortex labels Sep 13, 2020
@bboreham
Copy link
Contributor Author

I suspect this, since taking it out makes the symptom go away:

cortex/pkg/cortex/cortex.go

Lines 275 to 276 in f6122f4

t.Cfg.Server.GRPCMiddleware = append(t.Cfg.Server.GRPCMiddleware,
tracing.UnaryServerInterceptor(opentracing.GlobalTracer()),

@pracucci
Copy link
Contributor

You're right. I'm checking how we could fix it without loosing Thanos traces (which are quite useful when debugging the blocks storage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ingester type/observability To help know what is going on inside Cortex
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants