Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing at_modifier_enabled defult value or delete this configuration #4927

Closed
songjiayang opened this issue Oct 20, 2022 · 3 comments · Fixed by #4935
Closed

Changing at_modifier_enabled defult value or delete this configuration #4927

songjiayang opened this issue Oct 20, 2022 · 3 comments · Fixed by #4935

Comments

@songjiayang
Copy link
Contributor

songjiayang commented Oct 20, 2022 •
edited

The @ modifer to stable with Prometheus v2.33, to see the PR #10121 , Whether the default value can be changed to true or delete related configuration.

I think it's time to simple cortex configurations.
@yeya24
Copy link
Collaborator

yeya24 commented Oct 21, 2022

Agree we should enable this option by default. Same as the negative offset feature.

@alanprot
Copy link
Member

I agree as well. Do you wanna raise a pr for it ?

@songjiayang
Copy link
Contributor Author

very happy to

songjiayang added a commit to tsclub/cortex that referenced this issue Oct 22, 2022
@songjiayang
Removes -querier.at_modifier_enabled CLI flag and enable PromQL @…
f2fb672 
… modifier always (cortexproject#4927)

Signed-off-by: songjiayang <songjiayang1@gmail.com>
@songjiayang songjiayang mentioned this issue Oct 22, 2022
Merged
3 tasks
songjiayang added a commit to tsclub/cortex that referenced this issue Oct 22, 2022
@songjiayang
Removes -querier.at_modifier_enabled CLI flag and enable PromQL @…
67a3ce2 
… modifier always (cortexproject#4927)

Signed-off-by: songjiayang <songjiayang1@gmail.com>
songjiayang added a commit to tsclub/cortex that referenced this issue Oct 24, 2022
@songjiayang
Removes -querier.at_modifier_enabled CLI flag and enable PromQL @…
5c63dad 
… modifier、negative offset always (cortexproject#4927)

Signed-off-by: songjiayang <songjiayang1@gmail.com>
songjiayang added a commit to tsclub/cortex that referenced this issue Oct 25, 2022
@songjiayang
Removes -querier.at_modifier_enabled CLI flag and enable PromQL @…
ca896f7 
… modifier, negative offset always (cortexproject#4927)

Signed-off-by: songjiayang <songjiayang1@gmail.com>
songjiayang added a commit to tsclub/cortex that referenced this issue Oct 25, 2022
@songjiayang
Removes -querier.at_modifier_enabled CLI flag and enable PromQL @…
08fb699 
… modifier, negative offset always. (cortexproject#4927)

Signed-off-by: songjiayang <songjiayang1@gmail.com>
songjiayang added a commit to tsclub/cortex that referenced this issue Oct 25, 2022
@songjiayang
Enable PromQL @ modifier, negative offset always (cortexproject#4927)
34e0301 
Signed-off-by: songjiayang <songjiayang1@gmail.com>
songjiayang added a commit to tsclub/cortex that referenced this issue Oct 25, 2022
@songjiayang
Enable PromQL @ modifier, negative offset always (cortexproject#4927)
897d1f0 
Signed-off-by: songjiayang <songjiayang1@gmail.com>
songjiayang added a commit to tsclub/cortex that referenced this issue Oct 25, 2022
@songjiayang
Enable PromQL @ modifier, negative offset always (cortexproject#4927)
5c96486 
Signed-off-by: songjiayang <songjiayang1@gmail.com>
songjiayang added a commit to tsclub/cortex that referenced this issue Oct 25, 2022
@songjiayang
Enable PromQL @ modifier, negative offset always (cortexproject#4927)
bd38928 
Signed-off-by: songjiayang <songjiayang1@gmail.com>
songjiayang added a commit to tsclub/cortex that referenced this issue Oct 25, 2022
@songjiayang
Enable PromQL @ modifier, negative offset always (cortexproject#4927)
fa3a713 
Signed-off-by: songjiayang <songjiayang1@gmail.com>
songjiayang added a commit to tsclub/cortex that referenced this issue Oct 25, 2022
@songjiayang
Enable PromQL @ modifier, negative offset always (cortexproject#4927)
930f139 
Signed-off-by: songjiayang <songjiayang1@gmail.com>
songjiayang added a commit to tsclub/cortex that referenced this issue Oct 25, 2022
@songjiayang
Enable PromQL @ modifier, negative offset always (cortexproject#4927)
465da88 
Signed-off-by: songjiayang <songjiayang1@gmail.com>
alvinlin123 pushed a commit that referenced this issue Oct 25, 2022
@songjiayang
Enable PromQL @ modifier, negative offset always (#4927) (#4935)
c21eb69 
Signed-off-by: songjiayang <songjiayang1@gmail.com>

Signed-off-by: songjiayang <songjiayang1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable PromQL @ modifier always tsclub/cortex
3 participants
@songjiayang @alanprot @yeya24