Make TSDB max exemplars config per tenant #5016
Labels
component/ingester
good first issue
These are great first issues. If you are looking for a place to start, start here!
Comments
yeya24
added
component/ingester
good first issue
sahnib
pushed a commit
to sahnib/cortex
that referenced
this issue
Jan 5, 2023
Signed-off-by: sahnib <sahnib@amazon.com>
sahnib
pushed a commit
to sahnib/cortex
that referenced
this issue
Jan 5, 2023
Signed-off-by: sahnib <sahnib@amazon.com>
sahnib
pushed a commit
to sahnib/cortex
that referenced
this issue
Jan 5, 2023
Signed-off-by: sahnib <sahnib@amazon.com>
sahnib
pushed a commit
to sahnib/cortex
that referenced
this issue
Jan 5, 2023
Signed-off-by: sahnib <sahnib@amazon.com>
3 tasks
yeya24
pushed a commit
that referenced
this issue
Feb 2, 2023
* Make TSDB max exemplars config per tenant - #5016 Signed-off-by: sahnib <sahnib@amazon.com> * Fix documentation as per new flags Signed-off-by: sahnib <sahnib@amazon.com> * Enable hot reload of max exemplars value. Signed-off-by: sahnib <sahnib@amazon.com> * Fix goimports in ingester. Signed-off-by: sahnib <sahnib@amazon.com> * Rename config flag, and method to be more generic towards updating tsdb config. Signed-off-by: sahnib <sahnib@amazon.com> * Remove un-intended single process config change. Signed-off-by: sahnib <sahnib@amazon.com> * Remove un-necessary logging. Signed-off-by: sahnib <sahnib@amazon.com> * Add fallback on previous limit in block storage config Signed-off-by: sahnib <sahnib@amazon.com> * Added unit-test cases for fallback logic, and updated docs. Signed-off-by: sahnib <sahnib@amazon.com> --------- Signed-off-by: sahnib <sahnib@amazon.com>
alexqyle
pushed a commit
to alexqyle/cortex
that referenced
this issue
May 2, 2023
* Make TSDB max exemplars config per tenant - cortexproject#5016 Signed-off-by: sahnib <sahnib@amazon.com> * Fix documentation as per new flags Signed-off-by: sahnib <sahnib@amazon.com> * Enable hot reload of max exemplars value. Signed-off-by: sahnib <sahnib@amazon.com> * Fix goimports in ingester. Signed-off-by: sahnib <sahnib@amazon.com> * Rename config flag, and method to be more generic towards updating tsdb config. Signed-off-by: sahnib <sahnib@amazon.com> * Remove un-intended single process config change. Signed-off-by: sahnib <sahnib@amazon.com> * Remove un-necessary logging. Signed-off-by: sahnib <sahnib@amazon.com> * Add fallback on previous limit in block storage config Signed-off-by: sahnib <sahnib@amazon.com> * Added unit-test cases for fallback logic, and updated docs. Signed-off-by: sahnib <sahnib@amazon.com> --------- Signed-off-by: sahnib <sahnib@amazon.com> Signed-off-by: Alex Le <leqiyue@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Right now
blocks-storage.tsdb.max-exemplarsis a global configuration. In a multitenant environment, if tenants that need exemplars and tenants that don't need exemplars are sharing the same ingester cluster, all tenants's TSDB will allocate a queue for exemplars even if some of them don't really need it.Describe the solution you'd like
Make max exemplars configuration per tenant and move it to limits.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: