When we share a cache amongst multiple stores, ensure it is only stopped once. #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
force-pushed
the
1085-stop-cache-once
branch
from
e87e650
to
6686784
Compare
|
Any good way to write a test for this fix/the panic? |
tomwilkie
force-pushed
the
1085-stop-cache-once
branch
from
6686784
to
411936b
Compare
|
Good call @csmarchbanks! I was wrong in my initial suggestion - its not the shared index cache (which is never stopped), but in c824ad2 we shared the chunk cache, and it was that which was failing. We don't share it anymore (after @bboreham's YAML changes). I've changes the PR to properly stop the index cache now, which still triggers the bug. And fixes it. |
tomwilkie
force-pushed
the
1085-stop-cache-once
branch
from
411936b
to
4b2b40a
Compare
Also, plumb through Stop on StorageClient, so the cachingStorageClient can stop its cache. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
…ped once. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
tomwilkie
force-pushed
the
1085-stop-cache-once
branch
from
4b2b40a
to
b630420
Compare
csmarchbanks
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1085
Signed-off-by: Tom Wilkie tom.wilkie@gmail.com