Remove chunk store parallelisation; add backoff #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will need post merge review #97 |
tomwilkie
changed the title
jml
reviewed
Nov 8, 2016
| if err := i.flushChunks(ctx, op.fp, series.metric, chunks); err != nil { | ||
| err := i.flushChunks(ctx, op.fp, series.metric, chunks) | ||
| if err != nil { | ||
| if awsErr, ok := err.(awserr.Error); ok && awsErr.Code() == provisionedThroughputExceededException { |
There was a problem hiding this comment.
Instrumenting here would help fix https://github.com/weaveworks/monitoring/issues/12.
(No change required, immediately. One of us will get to it soon enough.)
There was a problem hiding this comment.
Yes! Instrumentation would be good for this. Will do it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're battling with overloading dynamoDB, so anything that makes it easier to understand...