Added integration build tag to integration tests. #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sitting next to @bwplotka and he says "go for it" |
|
@pstibrany In the meanwhile, could you rebase and add the tag to newly introduced tests? If I'm not mistaken, there should be something. |
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Done. |
bwplotka
approved these changes
Feb 26, 2020
simonswine
pushed a commit
to grafana/e2e
that referenced
this pull request
Jan 13, 2022
…ex#2164) * Added integration build tag to integration tests. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Use tags= syntax Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Fix confused linter complaining about unused symbols. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Added integration tag. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR adds
integrationtag to Cortex integration tests, so that they don't run by default when doing simplego test ./...in main Cortex directory.To run integration tests too, one needs to use
-tags=integrationflag togo test.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]