No globally registered metrics in pkg/querier #2210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
As next step to solve #2204 and #1512 I've iterated over all metrics registered in
pkg/querier
and refactored the code to:prometheus.Registerer
in input in each componentpromauto.With()
I've also introduced a new integration test to make sure that now
cortex_frontend_*
andcortex_query_frontend_*
metrics are exposed only by the query-frontend service (same test will be enriched in subsequent PRs once more packages will be refactored).Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]