Rename rest of the dynamodb flags #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamve
force-pushed
the
nuke-final-dynamodb
branch
from
133bb9d
to
e3c3152
Compare
gouthamve
force-pushed
the
nuke-final-dynamodb
branch
from
e3c3152
to
d4a323d
Compare
tomwilkie
reviewed
Mar 30, 2020
tomwilkie
reviewed
Mar 30, 2020
tomwilkie
reviewed
Mar 30, 2020
tomwilkie
approved these changes
Mar 30, 2020
gouthamve
force-pushed
the
nuke-final-dynamodb
branch
from
d4a323d
to
158821f
Compare
Fixes cortexproject#2254 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
nuke-final-dynamodb
branch
from
158821f
to
a3db727
Compare
pracucci
reviewed
Mar 31, 2020
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
bboreham
reviewed
Mar 31, 2020
| @@ -45,6 +45,11 @@ | |||
| - `-redis.password` --> `-store.chunks-cache.redis.password` | |||
| - `-redis.timeout` --> `-store.chunks-cache.redis.timeout` | |||
| * [CHANGE] Rename the `-store.chunk-cache-stubs` to `-store.chunks-cache.cache-stubs` to be more inline with above. | |||
| * [CHANGE] Change prefix of flags `-dynamodb.periodic-table.*` to `-table-manager.index-table.*`. #2359 | |||
There was a problem hiding this comment.
Weren't these already removed by #2221 ?
There was a problem hiding this comment.
Oh I get it - these are the scaling flags. So the description here could be made clearer by saying that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2254
Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]