Fix memory leak in blocks storage ingesters #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
approved these changes
May 12, 2020
bboreham
reviewed
May 21, 2020
| return result | ||
| } | ||
|
|
||
| func copyString(in string) string { |
There was a problem hiding this comment.
In pkg/util/extract/extract.go we do string([]byte(label.Value))
There was a problem hiding this comment.
I know, I was just afraid that Go compiler can easily optimize that away as no-op.
There was a problem hiding this comment.
Also in pkg/ingester/index/index.go yay DRY.
|
Very similar to #1897. In the 'v1' ingester, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In a production cluster running the blocks storage we've seen a large portion of the inuse heap retaining memory allocate by
grpc.recvMsg(). This is caused by the fact thatFromLabelAdaptersToLabelsWithCopy()doesn't do a deep copy but reuse input strings (which are read-only slice pointers).In this PR we're fixing it doing a deep copy.
Credits: the root cause has been spotted and fixed by @pstibrany. I've just done double checks and opening the PR for it.
Given the same exact test scenario, this is the
recvMsg()allocations before the fix:And this is after the fix:
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]