Decoupled blocks deletion from compaction #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
approved these changes
May 22, 2020
|
|
||
| // Ensure an initial cleanup occurred before starting the compactor. | ||
| if err := services.StartAndAwaitRunning(ctx, c.blocksCleaner); err != nil { | ||
| return errors.Wrap(err, "failed to start the blocks cleaner") |
There was a problem hiding this comment.
It doesn't matter too much in Cortex, but it would be good to call ringSubservices.StopAsync() if not nil. (Or StopAsync can be make to work with nil receiver too, which would be nice.)
There was a problem hiding this comment.
Very good point. Done.
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
While running the blocks compactor at scale, we reliased that blocks marked for deletion could be potentially never deleted if the compactor is busy all the time compacting blocks.
In this PR I've decoupled blocks deletion from compaction, so that blocks deletion is not blocked by a busy compactor.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]