more metrics in purger for monitoring delete requests processing progress #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
approved these changes
Jun 16, 2020
Comment on lines
+475
to
+477
| dp.metrics.oldestPendingDeleteRequestAgeSeconds.Set(float64(now.Sub(oldestPendingRequestCreatedAt) / time.Second)) | ||
| dp.metrics.pendingDeleteRequestsCount.Set(float64(pendingDeleteRequestsCount)) | ||
|
|
There was a problem hiding this comment.
This will only update metrics after all delete requests have plans for them built. Is that OK?
There was a problem hiding this comment.
Yes, that is the only option right now because if we change the count as we go through each delete request the partially updated value could get scraped and we would see unexpected jumps in the number of pending requests.
There was a problem hiding this comment.
This could be done by refactoring the code to find the requests to process as well as do a count of pending requests and build the plans after updating the metric. What do you think?
pracucci
approved these changes
Jun 17, 2020
…ress Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
sandeepsukhani
force-pushed
the
purger-metrics
branch
from
13923b4
to
c4c502e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds the following 3 new metrics for monitoring the progress of the processing of delete request:
purger_load_pending_requests_attempts_total: Number of attempts that were made to load pending requests with status.purger_oldest_pending_delete_request_age_seconds: Age of oldest pending delete request in seconds.purger_pending_delete_requests_count: Count of requests which are in process or are ready to be processed.This PR also loads new delete requests for processing on startup instead of waiting for the first tick, which is an hour now.