Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chunks flushing bugs #2778

Merged
merged 7 commits into from Jul 1, 2020
Merged

Fix chunks flushing bugs #2778

merged 7 commits into from Jul 1, 2020

Commits on Jun 29, 2020

  1. Add test case demonstrating bug and panic from issue 2743. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    fb5f0b6 View commit details
    Browse the repository at this point in the history

  2. Several fixes: 

    - if there are no unflushed chunks, shouldFlushSeries in immediate mode
  returns noFlush
- flushUserSeries works with a copy of chunk descriptors slice (not copy
  of descriptors themselves, since slice has a pointers to them).
  This helps to prevent panic in issue 2743
- Don't remove entire series from memory on immediate flush.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    1f7f9d7 View commit details
    Browse the repository at this point in the history

  3. Added CHANGELOG.md 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    1c8e5bb View commit details
    Browse the repository at this point in the history

  4. Added cortex_ingester_flush_series_in_progress metric and fix integra… 

    …tion test.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    121beca View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG.md wording. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    8b557bc View commit details
    Browse the repository at this point in the history

  6. Fix misleading messages. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    9943ee0 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. Merge branch 'master' into flushing-bugs

    @pstibrany
    pstibrany committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    39a32f0 View commit details
    Browse the repository at this point in the history