Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add injectable middlewares to bucket client #3278

Merged
merged 4 commits into from Oct 9, 2020
Merged

Add injectable middlewares to bucket client #3278

merged 4 commits into from Oct 9, 2020

Conversation

jtlisi
Copy link
Contributor

@jtlisi jtlisi commented Oct 4, 2020

What this PR does:

  • This adds a config field for injecting middlewares when creating a bucket client to allow for the clients created within modules to be created with these middlewares.
  • This approach is overtly simple and a factory approach similar to the Ruler may be preferable.

@jtlisi jtlisi marked this pull request as draft October 4, 2020 20:25
@jtlisi jtlisi marked this pull request as ready for review October 5, 2020 12:55
pstibrany
pstibrany approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with nits.

pkg/storage/tsdb/bucket_client.go Outdated Show resolved Hide resolved
pkg/storage/tsdb/config.go Outdated Show resolved Hide resolved
pracucci
pracucci approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's simple but if it works for your use case it LGTM.

@MichelHollands MichelHollands mentioned this pull request Oct 7, 2020
Closed
3 tasks
@jtlisi
feat: add middleware config field
0c1d298 
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
@jtlisi
fix: rename Middleware to Middlewares
3a7dd64 
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
@jtlisi
fix: rename Middleware to Middlewares
19dbe9e 
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
@jtlisi
address PR comments
a7cbfb1 
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
@jtlisi jtlisi merged commit 69ffb56 into master Oct 9, 2020
@jtlisi jtlisi deleted the 20201004_extend_bucket branch October 9, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstibrany pstibrany pstibrany approved these changes

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtlisi @pstibrany @pracucci