chore: ensure internalQuerier utilizes identical authMiddleware to API #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
pracucci
force-pushed
the
20201030_use_api_middleware
branch
from
c1d37e9
to
267dd4e
Compare
csmarchbanks
pushed a commit
that referenced
this pull request
Nov 3, 2020
#3439) Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Merged
pracucci
pushed a commit
that referenced
this pull request
Nov 10, 2020
* Cut release 1.5.0-rc.0 (#3417) Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com> * Deploy on master or tags (#3419) Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com> * Properly calculate image tag in GitHub Actions (#3423) Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com> * fix: register querier routes explicitly with handler for instrumentation (#3436) * fix: register querier routes explicitly with handler for instrumentation Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * fix: use legacy prefix for querier routes Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * remove unneeded changelog entry Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * ensure the internal querier router uses the Server prefix Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * simplify prefixes Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * fix import issue caused by IDE Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * chore: ensure internalQuerier utilizes identical authMiddleware to API (#3439) Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * Cut release 1.5.0-rc.1 Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com> * Cut release 1.5.0 (#3473) * Cut release 1.5.0 * Update versions in k8s/ and docs/ Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com> Co-authored-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR ensures the authentication middleware used by the internalQuerier is the same that is used by the API struct. I was worried this might be causing an issue with queries for single binary users with
no org iderrors, however, I manually verified it is not. Currently, this isn't causing an issue because the query-frontend will create thex-scope-orgidheader withfakeas a value so theAuthenticateUsermiddleware is valid. However, this will ensure any changes made to the auth middleware used by the API in the future will also be added to this internalHandler..