Better layout for companies logos in the website #3720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
approved these changes
Jan 20, 2021
| padding: 10px; | ||
| width: 180px; | ||
| height: 100px; | ||
| border: 1px solid #dedede; |
There was a problem hiding this comment.
On your screenshot the border looks like leftover from debugging. Do you plan to keep it?
There was a problem hiding this comment.
Yes, I wanted to introduce visual boxes. WDYT?
There was a problem hiding this comment.
As it is now, they are too subtle, and look like forgotten leftover. If you want to keep them, I would suggest using higher contrast. (Personally I would leave them out, I don't think boxes around these logos add anything).
There was a problem hiding this comment.
The box visually helps to give each logo the same weight. I've added a light drop shadow to better emphasis it.
There was a problem hiding this comment.
That's subtle, but looks better to me. Now it doesn't look like a bug anymore :)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
improve-companies-logos-layout
branch
from
dd3ec24
to
2dcb317
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The companies logos layout in the website is not much pretty. I think we should give each logo the same visibility. In this PR I'm proposing to use a fixed size box to include the company logo. I've cropped few logos, trimming transparent pixels, to let them scale nicely within the box.
Before:
After:
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]