Ensure missing runtime ingester settings are nil #4246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that omitted or missing ingester configuration that is part of runtime configuration is treated as `nil` instead of an empty object. This fixes an issue where the settings in the empty object were overriding global default ingester limits. Fixes #4228 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
pracucci
approved these changes
Jun 3, 2021
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nick Pillitteri nick.pillitteri@grafana.com
What this PR does:
Make sure that omitted or missing ingester configuration that is
part of runtime configuration is treated as
nilinstead of anempty object. This fixes an issue where the settings in the empty
object were overriding global default ingester limits.
Which issue(s) this PR fixes:
Fixes #4228
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]