Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose configuration of memberlist packet compression. #4346

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Expose configuration of memberlist packet compression. #4346

merged 3 commits into from
Jul 9, 2021

Commits on Jul 9, 2021

  1. Expose configuration of memberlist packet compression. 

    Allows manually specifying whether memberlist should compress packets
via a new configuration flag: `-memberlist.enable-compression`.

This typically has little benefit for Cortex, as the ring state messages
are already compressed with Snappy, the second layer of compression does
not achieve any additional saving. It's not clear cut whether there
might still be some benefit for internal memberlist messages; this needs
to be evaluated in a environment of some reasonable scale.

Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
    @stevesg
    stevesg committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    21f1edd View commit details
    Browse the repository at this point in the history

  2. Review comments. 

    Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
    @stevesg
    stevesg committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    e49b9a7 View commit details
    Browse the repository at this point in the history

  3. Review comments. 

    Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
    @stevesg
    stevesg committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    2d3f57e View commit details
    Browse the repository at this point in the history