Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update caching_bucket according to thanos changes #4651

Closed
wants to merge 1 commit into from
Closed

update caching_bucket according to thanos changes #4651

wants to merge 1 commit into from

Conversation

akanshat
Copy link

@akanshat akanshat commented Feb 20, 2022 •
edited

Signed-off-by: akanshat akanshat1999@gmail.com

What this PR does:
Updates caching_bucket in cortex with the new changes introduced with groupcache in package store and storecache in Thanos.
Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@akanshat
Copy link
Author

@GiedriusS I wanted to update cortex to point to Thanos with our refactored packages. I ran go get github.com/thanos-io/thanos@main but after running go mod vendor I seem to have changed 400 files. Is this correct? 😵‍💫

GiedriusS
GiedriusS approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The changes come from the vendored Go modules. Not sure why Cortex still does this 🤔

@akanshat akanshat marked this pull request as ready for review February 21, 2022 07:37
@bwplotka
Copy link
Contributor

👍🏽

@akanshat akanshat mentioned this pull request Jun 10, 2022
Merged
2 tasks
@stale
Copy link

stale bot commented Jun 11, 2022

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 11, 2022
@bwplotka
Copy link
Contributor

Any chances for review on this?

@stale stale bot removed the stale label Jun 16, 2022
@bwplotka
Copy link
Contributor

bwplotka commented Jun 16, 2022 •
edited

It is making us (Thanos project) to use fork of Cortex

@alanprot
Copy link
Member

I will try to take a look before EOW.

Sorry for the delay!

@alanprot
Copy link
Member

@GiedriusS Can your rebase this?

@akanshat
Copy link
Author

Sorry for looking at this so late, I will rebase this over the weekend.

@akanshat
update caching_bucket according to thanos changes
d4d58d4 
Signed-off-by: akanshat <akanshat1999@gmail.com>
@akanshat
Copy link
Author

@alanprot rebased this 😄

@alanprot
Copy link
Member

Build failed! =/

@alanprot
Copy link
Member

alanprot commented Jul 8, 2022 •
edited

Hi..

Im trying to update thanos to main on #4780

@alanprot
Copy link
Member

I will close this as Thanos was updated on #4780

@alanprot alanprot closed this Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

@alvinlin123 alvinlin123 Awaiting requested review from alvinlin123

Assignees

@alanprot alanprot

Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akanshat @bwplotka @alanprot @GiedriusS