Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit time for gossip on ring #4750

Merged
merged 1 commit into from Jun 17, 2022

Conversation

danielblando
Copy link
Collaborator

Signed-off-by: Daniel Blando ddeluigg@amazon.com

What this PR does:
Add a 30min window as max time to accept gossip updates. It avoids the possibility of a clock skew that can cause a non health pod to be available longer than expected.

Which issue(s) this PR fixes:
Fixes #4461

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Daniel Blando <ddeluigg@amazon.com>
@danielblando danielblando marked this pull request as draft June 15, 2022 17:30
@danielblando danielblando marked this pull request as ready for review June 15, 2022 18:08
@alanprot alanprot merged commit b3440e4 into cortexproject:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clock Skew can cause Ingesters to be unable to join the ring or be forgotten.
3 participants