Always request querier to return gzipped response #4960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Protasio <approtas@amazon.com>
alvinlin123
approved these changes
Nov 10, 2022
Signed-off-by: Alan Protasio <approtas@amazon.com>
yeya24
reviewed
Nov 10, 2022
| @@ -203,6 +203,9 @@ func (instantQueryCodec) EncodeRequest(ctx context.Context, r tripperware.Reques | |||
| } | |||
| } | |||
|
|
|||
| // Always ask gzip to the querier | |||
| h.Set("Accept-Encoding", "gzip") | |||
There was a problem hiding this comment.
If we configure the forwarded headers with Accept-Encoding here https://github.com/cortexproject/cortex/blob/master/pkg/querier/tripperware/roundtrip.go#L120 then is this still necessary?
There was a problem hiding this comment.
If we configured that before it would break everything.. as the result would be compressed and we were not expecting that! =/
We wanna send always.. not only when the customer send..
t00350320
pushed a commit
to t00350320/cortex
that referenced
this pull request
Nov 15, 2022
* Always request querier to return gzipped response Signed-off-by: Alan Protasio <approtas@amazon.com> * make lint happy Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <approtas@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Before this change, the query-frontend did not do any manipulation for instant queries and the QF was basically a proxy.
#4863 changed that and introduced middlewares also for instant queries in order to be able to manipulate the queries and implement the
shard byoptimization.The problem now is that we are not forwarding all the headers from the original request to the querier, including the
Accept-Encodingone and, this means that we stopped to gzip those requests between the query-frontend and the querier.PS: This was already the case for
query_rangeThis PR is changing this behavior and making the QF always ask the querier to return the response gzipped.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]