Rename max exemplars limit flag to ingester.max-exemplars. #5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
approved these changes
Feb 3, 2023
CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| # Changelog | |||
|
|
|||
| ## master / unreleased | |||
| * [CHANGE] Ingester: Rename max-exemplars limits config to ingester.max-exemplars instead of blocks-storage.tsdb.max-exemplars. #5122 | |||
There was a problem hiding this comment.
Changelog should be fine. I think we can safely remove the entry as the previous has not been released.
Signed-off-by: sahnib <sahnib@amazon.com>
alanprot
approved these changes
Feb 3, 2023
yeya24
approved these changes
Feb 3, 2023
alexqyle
pushed a commit
to alexqyle/cortex
that referenced
this pull request
May 2, 2023
…ject#5122) Signed-off-by: sahnib <sahnib@amazon.com> Signed-off-by: Alex Le <leqiyue@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sahnib sahnib@amazon.com
What this PR does:
This PR renames the
blocks-storage.tsdb.max-exemplarsflag in limits toingester.max-exemplars, because this limit is applied at ingestion time. The current name is confusing because it points to store gateway instead of ingester.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]