Multi level cache: check context add latency histogram #5596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
requested review from
alanprot,
friedrichg and
alvinlin123
and removed request for
alvinlin123 and
alanprot
Signed-off-by: Ben Ye <benye@amazon.com> add backfill histogram Signed-off-by: Ben Ye <benye@amazon.com> update changelog Signed-off-by: Ben Ye <benye@amazon.com> lint Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
check-ctx-multilevel-cache
branch
from
3f13486
to
d8230cf
Compare
alanprot
approved these changes
Oct 24, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This pr checks context in multi level cache and also adds two new histogram metric to track the latency to fetch data and backfill respectively.
The main reason to add the context check is for #5486. We have a backfill mechanism from higher level caches to lower level caches. For example, items exist in L2 cache (for example memcached) will backfill to L1 cache (inmemory cache).
However, when backfilling,
cache.StoreXXXmethod doesn't take context as parameter. When backfilling thousands of keys, it might take quite a long time. In my test environment, I can see backfilling to inmemory cache took more than 2 minute to finish due to high lock contention.The two histogram metrics are useful to measure the fetch and backfilling performance of multi level index cache.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]