Add contextual information and query statistics to log #5604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajagopalanand
force-pushed
the
log-ruler-query-stats
branch
from
1e4d111
to
8230bed
Compare
wenxu1024
reviewed
Oct 17, 2023
| } | ||
| ruleDetail := rules.FromOriginContext(ctx) | ||
| logMessage = append(logMessage, | ||
| "rule", ruleDetail.Name, | ||
| "query", qs, |
There was a problem hiding this comment.
this will be huge sometimes, and it will repetitive. We can add it for now. But later if we have log problems, we can remove it.
yeya24
approved these changes
Oct 18, 2023
rajagopalanand
force-pushed
the
log-ruler-query-stats
branch
3 times, most recently
from
72da911
to
1d370f0
Compare
emanlodovice
approved these changes
Oct 18, 2023
yeya24
approved these changes
Oct 18, 2023
|
Merge on green |
Signed-off-by: Anand Rajagopal <anrajag@amazon.com>
auto-merge was automatically disabled
October 18, 2023 18:46
Head branch was pushed to by a user without write access
rajagopalanand
force-pushed
the
log-ruler-query-stats
branch
from
1d370f0
to
01d068b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds some additional contextual information and query statistics to Ruler logs. This will be in effect only when query statistics is enabled
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]