Ruler HA - Proposal #5862
Open
Ruler HA - Proposal #5862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedrichg
reviewed
Apr 17, 2024
|
|
||
| The author proposes making a change to Prometheus to allow for pausing and resuming (or activating and deactivating) a rule group as described [here](https://github.com/prometheus/prometheus/issues/13630) | ||
|
|
||
| If the proposal is not accepted by Prometheus community, the proposal is to maintain a fork of Prometheus for Cortex with modified rule group evaluation behavior. This [draft PR](https://github.com/prometheus/prometheus/pull/13858) |
There was a problem hiding this comment.
maintain a fork of Prometheus for Cortex
Maintaining a full prometheus fork should be the last option, we don't have the capacity to maintain such fork. I think we could instead copy some of the prometheus ruler code here and call it experimental. do you think that could work or is that not a possibility?
There was a problem hiding this comment.
I believe this is doable. Probably need to copy all the ruler code from this package. I will need to figure out how to keep the code in sync with Prometheus upstream in terms of new features/updates
Signed-off-by: Anand Rajagopal <anrajag@amazon.com>
rajagopalanand
force-pushed
the
ruler-ha-proposal
branch
from
bcda709
to
dbc67ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Proposal for Ruler HA
I can add more details as necessary
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]