fix random string used in test allocating 50MB in Cortex binary #5903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <benye@amazon.com>
alanprot
approved these changes
Apr 26, 2024
|
:P My bad! haha |
Kramer0x0
pushed a commit
to Kramer0x0/cortex
that referenced
this pull request
Apr 26, 2024
…exproject#5903) Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
added a commit
to yeya24/cortex
that referenced
this pull request
Apr 27, 2024
…exproject#5903) Signed-off-by: Ben Ye <benye@amazon.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We initialize
RandomStringsinpkg/util/test_util.gowhich allocates 50MB data in heap in Cortex binary. This variable is used only in tests. The increased also showed up in the heap dump below.In this PR I removed the global variable for
RandomStringsinpkg/utiland move it to specific test files instead. This should reduce the memory usage in heap.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]