Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return more info on failure while persisting records in workflows #1430

Closed
petergrlica opened this issue Sep 11, 2023 · 0 comments · Fixed by #1571
Closed

Return more info on failure while persisting records in workflows #1430

petergrlica opened this issue Sep 11, 2023 · 0 comments · Fixed by #1571
Assignees
Labels
backend Backend server changes (GO) codebase improvements Various codebase improvements go Pull requests that update Go code
Milestone

Comments

@petergrlica
Copy link
Member

petergrlica commented Sep 11, 2023

When a user includes invalid or missing required values in record input in a workflow function, the error is displayed in server logs.

The error is not verbose enough, only the invalid record value input is presented to the user, along with the usual meta data on workflow and workflow step.

There needs to be more info presented, mainly the invalid field that is causing the error.

Workflow error:

15:54:19.674	WARN	workflow.session.exec	executed with errors	{"workflowID": "111", "runnerID": "111", "runnerRoles": [], "sessionID": "354354363533099009", "stateID": "354354363550007297", "stepID": "6", "functionRef": "composeRecordsCreate", "functionKind": "function", "execTime": "33.358159ms", "error": "invalid record value input"}

API error (with more info):

{"error":{"message":"1 issue(s) found","details":[{"kind":"invalidValue","message":"Invalid field value","meta":{"field":"LT","id":"354353949203103745","value":"new1"}}]}}
@petergrlica petergrlica added backend Backend server changes (GO) codebase improvements Various codebase improvements go Pull requests that update Go code labels Sep 11, 2023
@katrinDY katrinDY added this to the 2023.9.0 milestone Sep 18, 2023
@Fajfa Fajfa modified the milestones: 2023.9.0, 2023.9.1 Oct 30, 2023
@Fajfa Fajfa assigned petergrlica and unassigned KinyaElGrande Nov 13, 2023
@petergrlica petergrlica linked a pull request Nov 29, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend server changes (GO) codebase improvements Various codebase improvements go Pull requests that update Go code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants