Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error wrapping for compose record wf functions #1571

Merged
merged 1 commit into from Nov 30, 2023

Conversation

petergrlica
Copy link
Member

The following changes are implemented

Workflow record create and update functions have been wrapped with extra meta data when the values are invalid. It improves upon workflow developing, since before it was impossible to get info on which values were invalid for a specific module when a record was created.

It uses the Safe() method which is a stub for future secure values support, for now it always displays data.

Changes in the user interface:

Before
image

After
image

@petergrlica petergrlica added enhancement New feature or request backend Backend server changes (GO) go Pull requests that update Go code labels Nov 29, 2023
@petergrlica petergrlica linked an issue Nov 29, 2023 that may be closed by this pull request
Copy link
Contributor

@KinyaElGrande KinyaElGrande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fajfa Fajfa force-pushed the 2023.9.x-feature-workflow-error branch from a2259b6 to 47beebb Compare November 30, 2023 14:25
@Fajfa Fajfa merged commit 47beebb into 2023.9.x Nov 30, 2023
1 check passed
@Fajfa Fajfa deleted the 2023.9.x-feature-workflow-error branch November 30, 2023 14:25
@ghost
Copy link

ghost commented Dec 18, 2023

Thanks for addressing this one. No more workarounds / stripping down steps to see what is causing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend server changes (GO) enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return more info on failure while persisting records in workflows
3 participants