Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max-height issue for ItemPicker in safari #1221

Merged
merged 1 commit into from May 26, 2023

Conversation

katrinDY
Copy link
Contributor

The following changes are implemented

All cmps that use field picker cmp have max-height property changed to height

Changes in the user interface:

UI is the same. All of the items of a list are visible when scrolling

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

@katrinDY katrinDY requested a review from Fajfa May 23, 2023 14:32
@katrinDY katrinDY self-assigned this May 23, 2023
@katrinDY katrinDY added bug Something isn't working frontend Frontend code changes (Javascript, Typescript, Vue.js) labels May 23, 2023
@katrinDY katrinDY added this to the 2023.3.2 milestone May 23, 2023
@katrinDY katrinDY linked an issue May 23, 2023 that may be closed by this pull request
@katrinDY katrinDY force-pushed the 2023.3.x-scrolling-issue-safari branch from 2b824d5 to 947fe14 Compare May 26, 2023 11:03
@katrinDY katrinDY merged commit 947fe14 into 2023.3.x May 26, 2023
1 check passed
@katrinDY katrinDY deleted the 2023.3.x-scrolling-issue-safari branch May 26, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Frontend code changes (Javascript, Typescript, Vue.js)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Available/selected fields not scrollable in safari
2 participants