Add record filter preset saving #1227

kelanik8 · 2023-05-24T12:04:34Z

The following changes are implemented

TODO: Summary

Changes in the user interface:

TODO: Add screenshots, recordings or remove this section

Checklist when submitting a final (!draft) PR

Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
Code builds
All existing tests pass
All new critical code is covered by tests
PR is linked to the relevant issue(s)
Rebased with the target branch

client/web/compose/src/components/PageBlocks/RecordListBase.vue

locale/en/corteza-webapp-compose/block.yaml

client/web/compose/src/components/PageBlocks/RecordListBase.vue

Fajfa

Mistakenly selected Approve.

Fajfa

If i close the save as preset naming modal I cannot save another preset
Apply filter that you save as preset
If I press reset, the Custom filter still stays
This should be configurable, that means a new option in the record list configurator customFilterPresets, should be a checkbox in the filter preset section
Make sure the record list filter component is also configurable to be able to hide that save as preset button since its not just used in the record list. And make sure its disabled in other places record list filter is used. We only want custom presets on record list block.

Fajfa · 2023-05-30T12:34:01Z

client/web/compose/src/components/Common/RecordListFilter.vue

+      }
+
+      // Emit only value and not whole record with every filter
+      this.$emit('filter', this.processFilter())


This looks like you can just have a onSave function with (close = true, type = 'filter').
So that code doesn't repeat

Fajfa · 2023-05-30T12:35:05Z

client/web/compose/src/components/Public/Record/CustomFilterPreset/index.vue

+  name: 'CustomFilterPreset',
+
+  props: {
+    showCustomPresetFilterModal: {


can this be called visible, since based on where it is it is obvious it's the custom filter preset modal (component name)

Fajfa · 2023-05-30T12:35:13Z

client/web/compose/src/components/Public/Record/CustomFilterPreset/index.vue

+      default: false,
+    },
+
+    customFilter: {


this can just be called filter

Fajfa · 2023-05-30T12:37:42Z

client/web/compose/src/components/Public/Record/CustomFilterPreset/index.vue

+  },
+
+  watch: {
+    showCustomPresetFilterModal (val) {


Do the visible: { immediate: true, handler () } syntax please

Fajfa · 2023-05-30T12:37:43Z

client/web/compose/src/components/Public/Record/CustomFilterPreset/index.vue

+  },
+
+  created () {
+


No need for this if its empty

Fajfa · 2023-05-30T12:46:29Z

locale/en/corteza-webapp-compose/block.yaml

@@ -263,6 +263,12 @@ record:
 recordList:
  addRecord: Add
  cancelSelection: Cancel
+  customFilter: Custom filter
+  customPresetFilter: Custom preset filter


i dont think you use this anywhere

Fajfa · 2023-05-30T12:46:44Z

locale/en/corteza-webapp-compose/block.yaml

+  customFilter: Custom filter
+  customPresetFilter: Custom preset filter
+  presetFilter:
+    reset: Reset


This also wont be needed since you don't need reset

Fajfa · 2023-05-30T12:47:05Z

locale/en/corteza-webapp-compose/block.yaml

@@ -263,6 +263,12 @@ record:
 recordList:
  addRecord: Add
  cancelSelection: Cancel
+  customFilter: Custom filter
+  customPresetFilter: Custom preset filter
+  presetFilter:


filterPresets, presetFilter means something else

Fajfa · 2023-05-30T12:47:43Z

client/web/compose/src/components/Public/Record/CustomFilterPreset/index.vue

+        class="pt-0"
+      >
+        <b-form-group
+          :label="$t('recordList.presetFilter.filterName')"


label-class primary

Fajfa · 2023-05-30T12:48:45Z

client/web/compose/src/components/Public/Record/CustomFilterPreset/index.vue

+        >
+          <b-form-input
+            v-model="filterName"
+            required


the required here doesn't have any effect, you should however prevent saving(button should be disabled) if there is no filter name. You can also indicate its required by having a * in the label

Fajfa

If i close the save as preset naming modal I cannot save another preset
Saving as preset without applying filter doesn't apply and/or save the not applied one in the preset
If I press reset, the Custom filter still stays
This should be configurable, that means a new option in the record list configurator customFilterPresets, should be a checkbox in the filter preset section
Make sure the record list filter component is also configurable to be able to hide that save as preset button since its not just used in the record list. And make sure its disabled in other places record list filter is used. We only want custom presets on record list block.

katrinDY · 2023-06-05T14:58:06Z

Issues found after QC check:

on clone/copy block, preset and "normal" filters are not copied into the new block config. The value of the option to set custom filters is cloned/copied correctly. Steps to reproduce: in a block click on copy block or copy block button -> in the newly copied/clone block notice how both of the filters are not present. This is not supported for now
"normal" filters are not shown after page refresh
after adding a preset filter, it’s shown in active filter section but not applied to the RL. Steps to reproduce: add a filter -> set it as preset -> remove the "normal filter" -> apply the preset filter -> notice it's not respected

katrinDY · 2023-06-06T15:02:49Z

Last thing:

if I add a preset filter, it's applied normally but the same filter is added as a normal filter. Please see the gif. Notice how after choosing the preset filter, a normal filter is added and after removing the normal filter, the preset filter is removed. Steps to reproduce: add a filter -> set it as prefilter -> remove the normal filter -> the preset filter is removed This is expected

kelanik8 requested a review from Fajfa May 24, 2023 12:04

kelanik8 self-assigned this May 24, 2023

kelanik8 linked an issue May 24, 2023 that may be closed by this pull request

Add saving of record filter presets per user #1172

Closed

Fajfa approved these changes May 25, 2023

View reviewed changes

Fajfa requested changes May 25, 2023

View reviewed changes

Fajfa requested changes May 30, 2023

View reviewed changes

Fajfa approved these changes Jun 6, 2023

View reviewed changes

Add record filter preset saving

aa28be2

kelanik8 force-pushed the 2023.3.x-feature-add-record-filter-preset-saving branch from c550f3f to aa28be2 Compare June 7, 2023 10:47

Fajfa approved these changes Jun 7, 2023

View reviewed changes

kelanik8 merged commit aa28be2 into 2023.3.x Jun 7, 2023
1 check passed

kelanik8 deleted the 2023.3.x-feature-add-record-filter-preset-saving branch June 7, 2023 10:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add record filter preset saving #1227

Add record filter preset saving #1227

kelanik8 commented May 24, 2023

Fajfa left a comment

Fajfa left a comment •

edited

Fajfa May 30, 2023

Fajfa May 30, 2023

Fajfa May 30, 2023

Fajfa May 30, 2023

Fajfa May 30, 2023

Fajfa May 30, 2023

Fajfa May 30, 2023

Fajfa May 30, 2023

Fajfa May 30, 2023

Fajfa May 30, 2023

Fajfa left a comment

katrinDY commented Jun 5, 2023 •

edited

katrinDY commented Jun 6, 2023 •

edited

Add record filter preset saving #1227

Add record filter preset saving #1227

Conversation

kelanik8 commented May 24, 2023

The following changes are implemented

Changes in the user interface:

Checklist when submitting a final (!draft) PR

Fajfa left a comment

Choose a reason for hiding this comment

Fajfa left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Fajfa left a comment

Choose a reason for hiding this comment

katrinDY commented Jun 5, 2023 • edited

katrinDY commented Jun 6, 2023 • edited

Fajfa left a comment •

edited

katrinDY commented Jun 5, 2023 •

edited

katrinDY commented Jun 6, 2023 •

edited